Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sobek and goja respectfully #3795

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Update sobek and goja respectfully #3795

merged 1 commit into from
Jun 17, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Bump sobek and goja

Why?

To get some minor fixes

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added the dependencies Pull requests that update a dependency file label Jun 13, 2024
@mstoykov mstoykov added this to the v0.52.0 milestone Jun 13, 2024
@mstoykov mstoykov requested a review from a team as a code owner June 13, 2024 12:47
@mstoykov mstoykov requested review from oleiade and codebien and removed request for a team June 13, 2024 12:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.84%. Comparing base (c9e7018) to head (20e003a).

Current head 20e003a differs from pull request most recent head dc99271

Please upload reports for the commit dc99271 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3795      +/-   ##
==========================================
- Coverage   71.86%   71.84%   -0.02%     
==========================================
  Files         291      291              
  Lines       21260    21260              
==========================================
- Hits        15278    15274       -4     
- Misses       4918     4922       +4     
  Partials     1064     1064              
Flag Coverage Δ
ubuntu 71.78% <ø> (-0.01%) ⬇️
windows 71.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 23d8f91 into master Jun 17, 2024
23 checks passed
@mstoykov mstoykov deleted the bumpGojaAndSobek branch June 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants