Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Installation in non-default namespace not working #10048

Closed
jhedev opened this issue Jul 25, 2023 · 3 comments · Fixed by #10713 or #11648
Closed

Helm Chart: Installation in non-default namespace not working #10048

jhedev opened this issue Jul 25, 2023 · 3 comments · Fixed by #10713 or #11648
Labels
area/helm

Comments

@jhedev
Copy link
Contributor

jhedev commented Jul 25, 2023

Describe the bug
When deploying loki with the standard helm chart the read deployments error with level=warn ts=2023-07-25T07:25:18.070475696Z caller=dns_resolver.go:225 msg="failed DNS A record lookup" err="lookup query-scheduler-discovery.loki.svc.cluster.local. on 172.20.0.10:53: no such host".

I got it working when simply adding the namespace to the respective service (https://github.com/grafana/loki/blob/main/production/helm/loki/templates/backend/query-scheduler-discovery.yaml#L6-L10).
The linked service currently does not set the namespace. As such it cannot work when installed in a non-default namespace.

To Reproduce
Use the standard grafana/loki helm chart and install it in a non-default namespace.

Expected behavior
The installation to work

Environment:

  • AWS EKS

Screenshots, Promtail config, or terminal output
@jhedev
Copy link
Contributor Author

jhedev commented Jul 27, 2023

Now I also realised that the write components in the helm chart (see here https://github.com/grafana/loki/blob/028c12f624011b0693d8c7f74df39bc6a63ae5a4/production/helm/loki/templates/write/statefulset-write.yaml) do not set the right namespace.

All resources for the write part are created in the default namespace which caused my setup to fail. Recreating them in the correct namespace seems to work.

Am I missing something or is this a bug in the helm chart?

@ccureau
Copy link

ccureau commented Jul 27, 2023

I am also seeing this behavior with chart version 5.9.2. Using kustomize and installing in the loki namespace.

@jhedev jhedev mentioned this issue Sep 26, 2023
Merged
7 tasks
@jhedev
Copy link
Contributor Author

jhedev commented Sep 26, 2023

Submitted a PR for this: #10713

JStickler pushed a commit that referenced this issue Sep 27, 2023
@jhedev
helm: add namespace settings where missing (#10713)
df1254f 
**What this PR does / why we need it**:
It adds the right `namespace` values for some components in the helm
chart.

**Which issue(s) this PR fixes**:
Fixes #10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)


I hope I did things right w.r.t. the changelog/README changes for the
helm chart. Please let me know if I did something wrong :)
@simplydreamy0 simplydreamy0 mentioned this issue Jan 11, 2024
Merged
7 tasks
MichelHollands pushed a commit that referenced this issue Jan 12, 2024
@simplydreamy0
helm: added missing namespace to query-scheduler-discovery service (#…
6ae46dc 
…11648)

**What this PR does / why we need it**:
This PR adds the namespace attribute to the query-scheduler-service
descriptor because it is needed when deploying loki in non-default
namespace

**Which issue(s) this PR fixes**:
Fixes #10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)

I hope I did everything right with the changelog, chat and readme
updates since this my first PR, please tell me if something needs
fixing.
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
@jhedev @rhnasc
helm: add namespace settings where missing (grafana#10713)
4568119 
**What this PR does / why we need it**:
It adds the right `namespace` values for some components in the helm
chart.

**Which issue(s) this PR fixes**:
Fixes grafana#10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)


I hope I did things right w.r.t. the changelog/README changes for the
helm chart. Please let me know if I did something wrong :)
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
@simplydreamy0 @rhnasc
helm: added missing namespace to query-scheduler-discovery service (g…
2627017 
…rafana#11648)

**What this PR does / why we need it**:
This PR adds the namespace attribute to the query-scheduler-service
descriptor because it is needed when deploying loki in non-default
namespace

**Which issue(s) this PR fixes**:
Fixes grafana#10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)

I hope I did everything right with the changelog, chat and readme
updates since this my first PR, please tell me if something needs
fixing.
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
@jhedev
helm: add namespace settings where missing (grafana#10713)
af82e45 
**What this PR does / why we need it**:
It adds the right `namespace` values for some components in the helm
chart.

**Which issue(s) this PR fixes**:
Fixes grafana#10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@2cef71e)


I hope I did things right w.r.t. the changelog/README changes for the
helm chart. Please let me know if I did something wrong :)
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
@simplydreamy0
helm: added missing namespace to query-scheduler-discovery service (g…
e08f08c 
…rafana#11648)

**What this PR does / why we need it**:
This PR adds the namespace attribute to the query-scheduler-service
descriptor because it is needed when deploying loki in non-default
namespace

**Which issue(s) this PR fixes**:
Fixes grafana#10048 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@2cef71e)

I hope I did everything right with the changelog, chat and readme
updates since this my first PR, please tell me if something needs
fixing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm
Projects
None yet
Milestone
No milestone
3 participants
@ccureau @JStickler @jhedev