Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handoff vs just flushing #132

Closed
gouthamve opened this issue Dec 17, 2018 · 5 comments
Closed

Handoff vs just flushing #132

gouthamve opened this issue Dec 17, 2018 · 5 comments

Comments

@gouthamve
Copy link
Member

One of the main reasons Cortex has handoff is because of the sheer amount of writes that'll happen to the database. Here we're going to have magnitudes less streams, and maybe just flushing on exit is a better tradeoff.

@daixiang0
Copy link
Contributor

For multi-cpus, handoff is inevitable.
Besides, flushing does not impact on data right?

@gouthamve
Copy link
Member Author

No, but it does slow down rollouts. Can you explain what you mean by multi-CPUs?

@daixiang0
Copy link
Contributor

I mean multi-core cpus, which is common in production environment.

@tomwilkie
Copy link
Contributor

How do multi-core CPUs affect chunk handoffs on rolling upgrades?

@gouthamve I think you've point is valid, we should experiment to see if chunk handoffs are necessary on rolling upgrades.

@slim-bean
Copy link
Collaborator

Handoff was implemented in #794

JoaoBraveCoding pushed a commit to JoaoBraveCoding/loki that referenced this issue May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants