Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading client.batch-wait flag #280

Closed
ukrainian-im opened this issue Feb 3, 2019 · 1 comment · Fixed by #969
Closed

Misleading client.batch-wait flag #280

ukrainian-im opened this issue Feb 3, 2019 · 1 comment · Fixed by #969
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@ukrainian-im
Copy link

ukrainian-im commented Feb 3, 2019

As currently implemented, the flag name should probably be "client.line-wait",
as it controls max duration between stream.append.entry(), and not duration between send.batch().

Not clear what original intent was.

Either flag name/description should be changed, or implementation changed from

	for {
		maxWait.Reset(c.cfg.BatchWait)
		select {
                .
                .
                .
		}
	}

to

	maxWait.Reset(c.cfg.BatchWait)
	for {
		select {
                .
                .
                .
		case <-maxWait.C:
                      .
                      .
                     .
                      maxWait.Reset(c.cfg.BatchWait)
		}		
	}
@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 3, 2019
slim-bean pushed a commit that referenced this issue Sep 5, 2019
btaani pushed a commit to btaani/loki that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant