Move weaveworks/common back to upstream

[cyriltovena]

To not block some PR we moved weaveworks/common to a personal fork. Once weaveworks/common#153 is merged we can go back to upstream.

[ThoreKr]

As weaveworks/common#153 is more or less dead and waiting for a rebase I reopened a new (rebased) PR (weaveworks/common#167).

[clickyotomy]

Hello! Can I work on this after weaveworks/common#167 is merged?

[ThoreKr]

@clickyotomy If you are more familiar with the dependencies a bit of help in weaveworks/common#167 would be most welcome.

Initially it was only meant to be a rebase to resolve a merge conflict, but now the actual change has been reviewed again.

[ThoreKr]

@clickyotomy Please also take a look at my notes in #1051 as there is apparently another version in the vendor subdirectory.

[clickyotomy]

@ThoreKr, I am not familiar with the changes introduced in weaveworks/common#167, but I will try to help. :)

• I don't know what needs to be done here - should we include/replace localhost on all the tests?
• However, here - maybe we can get rid of HTTPListen{Port,Address} for TestErrorInstrumentationMiddleware, because it's probably not needed for that test.

How do I make changes to the PR? Fork from https://github.com/ThoreKr/weaveworks-common/tree/server-listen-addr and open a new one?

Regarding #1051, this repo was moved to go modules (#1062) for dependency management. We might just have to do a go mod edit -dropreplace=personal_fork[@v] and use the latest from upstream for this issue.

[ThoreKr]

@clickyotomy Me neither, I just rebased it. Maybe wait for comments from upstream whether it should be tested or not.

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[ThoreKr]

Still waiting for weaveworks-common.

Starting to get annoyed.

[ThoreKr]

@clickyotomy it's merged!