Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki: add back new /loki/api/v1/push endpoint #1046

Closed
wants to merge 1 commit into from

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Sep 23, 2019

/loki/api/v1/push was added in #1010 but was temporarily reverted. #1022 reintroduced changes from #1010 but inadvertently did not reintroduce the new push endpoint.

/loki/api/v1/push was added in grafana#1010 but was temporarily reverted. grafana#1022
reintroduced changes from grafana#1010 but inadvertently did not reintroduce
the new push endpoint.
@joe-elliott
Copy link
Member

Oh, I was working on this here: https://github.com/joe-elliott/loki/tree/update-push-path

I have added the new path and updated promtail to use the latest path. There is still a fluentd ruby plugin and docker driver I was going to update and test. Was planning on submitting sometime tomorrow.

If we just want to update the path immediately this works for me.

@rfratto
Copy link
Member Author

rfratto commented Sep 23, 2019

Ah, my bad, I was just on a roll with opening issues and small PRs. I'll close this in favor of your PR tomorrow.

@rfratto rfratto closed this Sep 23, 2019
@rfratto rfratto deleted the add-new-push-endpoint branch September 23, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants