-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with Cortex v0.3.0-rc.0 and resolve conflict #1047
Conversation
@cyriltovena Could you help to review? |
11093c7
to
75adaee
Compare
what's CI go version? I see this error:
google showed it should be related to GO version under 1.12? |
@gouthamve is cortex using 1.12 now ? |
I think it is using go 1.13 now.. cortexproject/cortex@9d6c4d1 |
We will have to wait for #1062 |
75adaee
to
1862407
Compare
@cyriltovena rebased with latest Loki code, could you plz help review again? |
f5f646f
to
e8a8559
Compare
e8a8559
to
8b4557b
Compare
I would prefer to wait for the final 0.3 |
make sense |
0.3 is out @mizeng if you want to resume the work. |
@cyriltovena seems no need. Loki works well with Cortex v0.3.0, seems someone fixed the conflict. |
…_timeout Add a timeout option for Cassandra access
What this PR does / why we need it:
Sync with Cortex and fix conflict, so it will not break Loki build.
Which issue(s) this PR fixes:
Fixes #1033
Special notes for your reviewer:
Checklist