Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with Cortex v0.3.0-rc.0 and resolve conflict #1047

Closed
wants to merge 1 commit into from

Conversation

mizeng
Copy link
Contributor

@mizeng mizeng commented Sep 24, 2019

What this PR does / why we need it:
Sync with Cortex and fix conflict, so it will not break Loki build.

Which issue(s) this PR fixes:
Fixes #1033

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@mizeng
Copy link
Contributor Author

mizeng commented Sep 24, 2019

@cyriltovena Could you help to review?

@mizeng
Copy link
Contributor Author

mizeng commented Sep 24, 2019

what's CI go version? I see this error:

#!/bin/bash -eo pipefail
make BUILD_IN_CONTAINER=false test
>> writing assets
GOOS=linux go generate -x -v ./pkg/promtail/server/ui
pkg/promtail/server/ui/assets_vfsdata.go
pkg/promtail/server/ui/doc.go
go run -tags=dev assets_generate.go
writing assets_vfsdata.go
CGO_ENABLED=1 go build -ldflags "-s -w -X github.com/grafana/loki/vendor/github.com/prometheus/common/version.Branch=pull/1047 -X github.com/grafana/loki/vendor/github.com/prometheus/common/version.Version=pull-1047-75adaee -X github.com/grafana/loki/vendor/github.com/prometheus/common/version.Revision=75adaee2 -X github.com/grafana/loki/vendor/github.com/prometheus/common/version.BuildUser=root@7f45bd800e3d -X github.com/grafana/loki/vendor/github.com/prometheus/common/version.BuildDate=2019-09-24T01:24:56Z" -tags netgo -o cmd/promtail/promtail ./cmd/promtail
# github.com/grafana/loki/vendor/github.com/prometheus/prometheus/tsdb/goversion
vendor/github.com/prometheus/prometheus/tsdb/goversion/init.go:17:9: undefined: _SoftwareRequiresGOVERSION1_12

google showed it should be related to GO version under 1.12?

@cyriltovena
Copy link
Contributor

@gouthamve is cortex using 1.12 now ?

@mizeng
Copy link
Contributor Author

mizeng commented Sep 25, 2019

I think it is using go 1.13 now.. cortexproject/cortex@9d6c4d1

@cyriltovena
Copy link
Contributor

We will have to wait for #1062

@mizeng mizeng changed the title sync with Latest Cortex and resolve conflict sync with Cortex v0.3.0-rc.0 and resolve conflict Oct 8, 2019
@mizeng
Copy link
Contributor Author

mizeng commented Oct 8, 2019

@cyriltovena rebased with latest Loki code, could you plz help review again?

@mizeng mizeng force-pushed the sync_cortex_20190923 branch 4 times, most recently from f5f646f to e8a8559 Compare October 8, 2019 10:25
@cyriltovena
Copy link
Contributor

I would prefer to wait for the final 0.3

@mizeng
Copy link
Contributor Author

mizeng commented Oct 12, 2019

make sense

@cyriltovena
Copy link
Contributor

0.3 is out @mizeng if you want to resume the work.

@mizeng
Copy link
Contributor Author

mizeng commented Oct 25, 2019

@cyriltovena seems no need. Loki works well with Cortex v0.3.0, seems someone fixed the conflict.

@mizeng mizeng closed this Oct 25, 2019
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…_timeout

Add a timeout option for Cassandra access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus version conflict with Cortex
2 participants