Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re Fix Docs: PR https://github.com/grafana/loki/pull/1053 got erased due to force push. #1073

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

flouthoc
Copy link
Contributor

Hi, Change in Following PR was erased due to force push ( major Docs update ) therefore adding it again.
#1053

Thanks

@flouthoc
Copy link
Contributor Author

@cyriltovena @slim-bean Could you guys please take a look.

@rfratto
Copy link
Member

rfratto commented Sep 26, 2019

Hi, I'm hesitant to just start adding unlinked YAML files into the docs folder now that we've restructured. Can you move those to an examples section in the loki-canary.md file?

Sorry for accidentally removing them when I rebased.

@flouthoc
Copy link
Contributor Author

@rfratto Sure.

@flouthoc
Copy link
Contributor Author

@rfratto Could you please check again I've edited it as per your suggestions.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfratto rfratto merged commit 1f0b7cc into grafana:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants