Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(stage): add docker and cri #1091

Merged
merged 3 commits into from
Oct 1, 2019
Merged

docs(stage): add docker and cri #1091

merged 3 commits into from
Oct 1, 2019

Conversation

daixiang0
Copy link
Contributor

Fix #1090

Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0
docs(stage): add docker and cri
3d5e048 
Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@rfratto mind have a look?

daixiang0 and others added 2 commits October 1, 2019 15:22
rfratto
rfratto approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing the work on this! I changed the grammar around a little bit and standardized the format of the new stage markdown files.

@rfratto rfratto merged commit ca6fce1 into grafana:master Oct 1, 2019
@daixiang0 daixiang0 deleted the add-stage branch October 2, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing docs on docker and cri pipeline stages
2 participants
@daixiang0 @rfratto