logging: removed some noise in logs from live-tailing #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oring due to stopped or closed tail request
sandeepsukhani
force-pushed
the
cleanup-tail-logging
branch
from
4f9b236
to
ebc4ab2
Compare
cyriltovena
reviewed
Oct 2, 2019
pkg/ingester/tailer.go
Outdated
| level.Error(util.Logger).Log("Error writing to tail client", fmt.Sprintf("%v", err)) | ||
| // Don't log any error due to tail client closing the connection | ||
| if !util.IsConnCanceled(err) { | ||
| level.Error(cortex_util.Logger).Log("Error writing to tail client", fmt.Sprintf("%v", err)) |
There was a problem hiding this comment.
Suggested change
| level.Error(cortex_util.Logger).Log("Error writing to tail client", fmt.Sprintf("%v", err)) | |
| level.Error(cortex_util.Logger).Log("msg","Error writing to tail client", "err", err) |
There was a problem hiding this comment.
Can you take this opportunity to rework you all your log messages as per above ? This is how gokit is supposed to be used. "k1","v1","k2","v2"
There was a problem hiding this comment.
Sure, will do. Thanks for the review!
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
more table-manager fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
removed some noise in logs generated by live tailing by detecting cases where connection is erroring due to stopped or closed tail request