Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify journal warning #1109

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Clarify journal warning #1109

merged 1 commit into from
Oct 2, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Oct 2, 2019

The current journal warning makes it seem like you're running promtail on a machine that doesn't have systemd. This PR tries to clarify that warning to instead specify that the promtail you are running wasn't compiled with journal support.

Journal support in promtail still requires being built on Linux with CGO_ENABLED=1.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 05f8e56 into master Oct 2, 2019
@rfratto rfratto deleted the journal-warning-clarify branch November 1, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants