Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Add support for passing arbitrary secrets #1111

Merged
merged 4 commits into from
Oct 9, 2019
Merged

helm: Add support for passing arbitrary secrets #1111

merged 4 commits into from
Oct 9, 2019

Conversation

ekarlso
Copy link
Contributor

@ekarlso ekarlso commented Oct 3, 2019 •
edited
Loading

Checklist

  • [ X] Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Starefossen
Copy link
Contributor

Nice work @ekarlso 👍

steven-sheehy
steven-sheehy suggested changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a solution that is specific to secrets, an extraVolumeMounts might be better as a more general approach. There is already an extraVolumes option so it can be paired with that.

@ekarlso
Copy link
Contributor Author

ekarlso commented Oct 8, 2019

@steven-sheehy Any updates ? :)

steven-sheehy
steven-sheehy approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
bump chart
f57401f 
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
cyriltovena approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit d4c5b09 into grafana:master Oct 9, 2019
@ekarlso ekarlso deleted the feat/secrets-support branch October 9, 2019 22:48
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@ekarlso @cyriltovena
helm: Add support for passing arbitrary secrets (grafana#1111)
5a38450 
* Add support for adding secrets and mounting

* Add possibility to pass arbitrary env

* Bump chart to 0.16.0

* bump chart

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starefossen Starefossen Starefossen approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekarlso @CLAassistant @Starefossen @cyriltovena @steven-sheehy