Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logql filter to match stages and drop capability #1112

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Oct 3, 2019

This adds filter expressions to the match stage such as :

  • {job="mysql"} |= "error"
  • {name="kafka"} |~ "tsdb-ops.*io:2003"
  • {instance=~"kafka-[23]",name="kafka"} != kafka.server:type=ReplicaManager

but also introduces a new property action that when set to drop will drop all matching entries.

Fixes #1092 and #553

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, look all good to me 👍

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not incredibly familiar with this, but it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to drop/ignore lines that don't match a given expression.
3 participants