boundscheck & partitioning fingerprints between blocks #11237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
owen-d
force-pushed
the
blooms/bounds-check
branch
from
1c4cb52
to
8a79e82
Compare
chaudum
reviewed
Nov 17, 2023
Comment on lines
+158
to
+160
| bounded := boundedRequests{ | ||
| bounds: block, | ||
| } |
There was a problem hiding this comment.
Does the slice reqs not need to be allocated?
|
|
||
| // reqs models a set of requests covering many fingerprints. | ||
| // consumers models a set of blocks covering different fingerprint ranges | ||
| func partitionFingerprintRange(reqs [][]model.Fingerprint, blocks []FingerprintBounds) (res []boundedRequests) { |
There was a problem hiding this comment.
You have a named return value, but you return the value also explicitly.
Personally I'm not a big fan of named return values, because they can hide allocation problems.
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/bounds-check
branch
from
8a79e82
to
50ea652
Compare
chaudum
approved these changes
Nov 17, 2023
|
Trivy scan found the following vulnerabilities:
|
jeschkies
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adds a few utilities for comparing fingerprints to blocks that cover a specific fingerprint range. Will likely need to be refactored with more comprehensive types, but the logic still applies.
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Adds a few utilities for comparing fingerprints to blocks that cover a specific fingerprint range. Will likely need to be refactored with more comprehensive types, but the logic still applies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few utilities for comparing fingerprints to blocks that cover a specific fingerprint range. Will likely need to be refactored with more comprehensive types, but the logic still applies.