Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: fix ciliumNetworkPolicy template in the chart #11963

Merged

Conversation

QuantumEnigmaa
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa commented Feb 15, 2024

What this PR does / why we need it:

This PR fixes the ciliumnetworkpolicy template file in the chart because in its current state, the ciliumNetworkPolicies are wrong. The toPorts field was not written properly and this was leading to network issues when deployed.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
@QuantumEnigmaa
Copy link
Contributor Author

@MichelHollands @JStickler it's me again ! Sorry to bother you again with this but this time should be the last on this topic

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit a955ba9 into grafana:main Feb 15, 2024
10 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants