Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Support using multiple buckets with AWS STS #12008

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

xperimental
Copy link
Collaborator

What this PR does / why we need it:

This changes the generated Loki configuration, so that the s3 configuration option is avoided, making it possible to specify more than one S3 bucket in the configuration.

Which issue(s) this PR fixes:

LOG-5086

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • CHANGELOG.md updated

@xperimental xperimental self-assigned this Feb 20, 2024
@xperimental xperimental requested review from periklis and a team as code owners February 20, 2024 18:17
@xperimental xperimental changed the title operator: Support configuring multiple buckets when using AWS STS operator: Support using multiple buckets with AWS STS Feb 20, 2024
@trevorwhitney
Copy link
Collaborator

we're moving some CI actions to GH action, you'll have to bring in the latest from main to get the checks to run

@periklis periklis changed the title operator: Support using multiple buckets with AWS STS fix(operator): Support using multiple buckets with AWS STS Feb 21, 2024
@periklis periklis merged commit 1f3e64b into grafana:main Feb 21, 2024
18 checks passed
@xperimental xperimental deleted the sts-multi-bucket branch February 21, 2024 16:44
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
…2008)

Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants