Simplify regexp's #1202
Merged
Simplify regexp's #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is mostly to remove redundant anchoring (as it makes people believe that Prometheus's regexp's aren't anchored by default, which will backfire badly at some point), but it also removes useless grouping (again to avoid confusion). Signed-off-by: beorn7 <beorn@grafana.com>
|
This looks about right to me, but Ed's probably the best person to review this. |
|
@slim-bean please rubberstamp. 😁 |
cyriltovena
approved these changes
Oct 28, 2019
|
Oh noes, you cannot properly merge in this repo! As a git fanboy, I'm terrified! 😁 |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Add a cap on bigChunk size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to remove redundant anchoring (as it makes people
believe that Prometheus's regexp's aren't anchored by default, which
will backfire badly at some point), but it also removes useless
grouping (again to avoid confusion).
This should not change the effective behavior. Not sure if that justifies a helm chart version bump.