Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [release-2.9.x] Remove docs about configs that are not released yet (#12111) #12115

Merged
merged 3 commits into from
Mar 26, 2024
Merged

docs: [release-2.9.x] Remove docs about configs that are not released yet (#12111) #12115

merged 3 commits into from
Mar 26, 2024

Conversation

Func86
Copy link
Contributor

@Func86 Func86 commented Mar 3, 2024

This partially reverts c719594

What this PR does / why we need it:
Avoid confusion.

Which issue(s) this PR fixes:
Fixes #12111

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Func86 Func86 requested a review from a team as a code owner March 3, 2024 12:05
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 3, 2024
JStickler
JStickler reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler changed the title [release-2.9.x] docs: Remove docs about configs that are not in 2.9.x (#12111) docs: [release-2.9.x] Remove docs about configs that are not in 2.9.x (#12111) Mar 26, 2024
@JStickler JStickler changed the title docs: [release-2.9.x] Remove docs about configs that are not in 2.9.x (#12111) docs: Remove docs about configs that are not in 2.9.x (#12111) Mar 26, 2024
@JStickler JStickler changed the title docs: Remove docs about configs that are not in 2.9.x (#12111) docs: Remove docs about configs that are not released yet (#12111) Mar 26, 2024
@JStickler JStickler changed the title docs: Remove docs about configs that are not released yet (#12111) docs: [release-2.9.x] Remove docs about configs that are not released yet (#12111) Mar 26, 2024
@JStickler JStickler merged commit e4f2258 into grafana:release-2.9.x Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@sandeepsukhani sandeepsukhani Awaiting requested review from sandeepsukhani

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Func86 @JStickler