Revert `name` label addition but keep the runtime change #12304

DylanGuedes · 2024-03-21T20:12:26Z

What this PR does / why we need it:

Remove the name label addition introduced previously. selectorLabels is a forbidden field so by changing it I'm breaking existing envs from upgrading

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

Reviewed the CONTRIBUTING.md guide (required)
Documentation added
Tests updated
CHANGELOG.md updated
- If the change is worth mentioning in the release notes, add add-to-release-notes label
Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

This reverts commit 38d8b62.

DylanGuedes added 2 commits March 21, 2024 17:09

Revert "Add name labels and modify runtime cfg name (#12291)"

87a00a3

This reverts commit 38d8b62.

But keep the runtime change

24ba621

DylanGuedes requested a review from a team as a code owner March 21, 2024 20:12

DylanGuedes changed the base branch from main to ewelch-distributed-helm-chart March 21, 2024 20:12

pull-request-size bot added size/XXL size/M labels Mar 21, 2024

github-actions bot added the area/helm label Mar 21, 2024

slim-bean approved these changes Mar 21, 2024

View reviewed changes

slim-bean merged commit 138e6f2 into ewelch-distributed-helm-chart Mar 21, 2024
6 of 8 checks passed

slim-bean deleted the actually-remove-the-name-label branch March 21, 2024 20:16

Provide feedback