feat: Improved Drain pattern extraction algorithm (+optimization pass) #13003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces a slightly modified Drain algorithm to extract patterns with the pattern-ingester.
Special notes:
Comparison between previous algorithm & this one:
Understandably higher CPU & allocations due to doing more work for each log line.
Total memory usage seems slightly lower, likely due to generating a better set of patterns & flatter tree
Tradeoff is better quality patterns (and there are probably a new more things we can try)
I've done an optimisation pass to streamline my initial nieve implementation to make this reasonable but its still about 2x the previous resource usage.
New-algorithm vs New-algorithm-with-optimizations: