Fix v1 label API to be Prometheus-compatible #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label and label values API will now return the expected form
of:
```json
{
"status": "success",
"data": [
"label1",
"label2",
"labeln"
]
}
```
rfratto
force-pushed
the
fix-label-api
branch
from
a1db41f
to
856e083
Compare
joe-elliott
reviewed
Nov 26, 2019
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Use go.etcd.io/bbolt import and vendor master etcd to we don't import github.com/coreos/... * Move code around - start a kv package with the interface, and subpackages for consul and etcd. * Add prefix to the config of the kvstore. NB This removed the `-consul.prefix` flag. * Split codec into its own package and prefix client into separate files. * Add unit tests and etcd mock. * Remove Client.PutBytes - its only used in one test, can be done with a CAS, and doesn't fit rest of interface with Codecs etc. * Instrument all ring clients, and add comments. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label and label values API will now return the expected form of:
{ "status": "success", "data": [ "label1", "label2", "labeln" ] }Fixes #1293.