chore(blooms): allocator is best effort; uses pool if available otherwise allocs #13286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wise allocs Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/mempool-best-effort
branch
2 times, most recently
from
bda9ca4
to
174e5e2
Compare
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/mempool-best-effort
branch
from
174e5e2
to
9d70670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we'd always return buffers to the pool, but ensuring this in the code is tricky & error prone. Instead, we'll treat allocators as best effort & measure them. This should probabilistically create the reuse we want in lieu of a more perfect solution and allow us to continue using & repopulating pools when we drop pointers.