Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blooms): Fix and improve build metrics #13360

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Jul 1, 2024

What this PR does / why we need it:

  • Remove log line that is too verbose and kinda useless when there are no gaps found for a given FP range.
  • Tasks metric
    • Fix to account for errors forwarded from the builder. Moved the metric update to the caller of the function that was updating the metric originally.
    • Set buckets that span up to hours instead of seconds
  • Add metric to track time spent in the planning phase

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title Fix and improve build metrics refactor(blooms): Fix and improve build metrics Jul 1, 2024
@salvacorts salvacorts marked this pull request as ready for review July 1, 2024 09:27
@salvacorts salvacorts requested a review from a team as a code owner July 1, 2024 09:28
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
@salvacorts salvacorts merged commit 23f17f8 into main Jul 1, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/bloom-refactor/better-task-planning-and-completion-metrics branch July 1, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants