Change /loki/api/v1/label to loki/api/v1/labels
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to keep the old endpoint so this isn't a breaking change? |
|
I had originally drafted this PR to have both and in the process of documenting decided to remove the old. I could be swayed either way on this honestly but part of me feels like just pulling off the bandaid here and removing it. Else we will have it forever. |
rfratto
approved these changes
Dec 5, 2019
slim-bean
force-pushed
the
add-labels-http
branch
from
39edb50
to
810ebf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1367
To be Prometheus compatible, this endpoint should be
loki/api/v1/labels