Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluentd: guard against nil values when sanitizing labels #1376

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Fluentd: guard against nil values when sanitizing labels #1376

merged 2 commits into from
Dec 5, 2019

Conversation

jstaffans
Copy link
Contributor

I tried updating to 1.2.4 and got these errors:

2019-12-05 22:16:01 +0200 [warn]: #1 got unrecoverable error in primary and no secondary error_class=NoMethodError error="undefined method `gsub' for nil:NilClass"

It seems that a guard condition for nil label values was omitted in 2b7f375.

@claassistantio
Copy link

claassistantio commented Dec 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cyriltovena
cyriltovena approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@cyriltovena cyriltovena merged commit 7b2fde3 into grafana:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstaffans @claassistantio @cyriltovena