Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decompression tracing instrumentation. #1445

Merged
merged 4 commits into from
Dec 20, 2019

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Dec 19, 2019

This adds a collection of decompression statistics in the logql engine.

/cc @Dieterbe I think this could be the be propagated from there to the API.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena
Copy link
Contributor Author

hold on I want to add deduping time.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM with one minor nit

pkg/chunkenc/memchunk.go Outdated Show resolved Hide resolved
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena
Copy link
Contributor Author

/cc @rfratto this is ready.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyriltovena cyriltovena merged commit fb76416 into grafana:master Dec 20, 2019
@cyriltovena cyriltovena deleted the decompression branch December 20, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants