Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loki helm chart] added ingress #1585

Merged
merged 3 commits into from
Jan 28, 2020
Merged

[loki helm chart] added ingress #1585

merged 3 commits into from
Jan 28, 2020

Conversation

monotek
Copy link
Contributor

@monotek monotek commented Jan 27, 2020 •
edited

Signed-off-by: André Bauer andre.bauer@kiwigrid.com

What this PR does / why we need it:

  • adds an ingress template

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@monotek monotek changed the title added ingress, use lable templates, removed namespace [loki helm chart] added ingress, use lable templates, removed namespace Jan 27, 2020
@claassistantio
Copy link

claassistantio commented Jan 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@cyriltovena
Copy link
Contributor

Nice @monotek , can you split the refactoring and ingress definition into a PR for each, this would makes it easier to review.

@monotek
Copy link
Contributor Author

monotek commented Jan 27, 2020 •
edited

Yes, but could take until tomorrow...

Do you wan't separate prs for every point?
Or just 1 for the ingress and one for the labels + namespace stuff?

added ingress template
5ca5fbf 
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
@monotek
Copy link
Contributor Author

monotek commented Jan 28, 2020 •
edited

Changed the pr to contain only the ingress change.

I'll create a second pr with the refactor stuff when this one is merged.

@monotek monotek changed the title [loki helm chart] added ingress, use lable templates, removed namespace [loki helm chart] added ingress Jan 28, 2020
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jan 28, 2020
@cyriltovena cyriltovena removed the request for review from tomwilkie January 28, 2020 14:31
raised loki-stack chart version to 0.29.0
1833c6e 
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
cyriltovena
cyriltovena approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit b6f1088 into grafana:master Jan 28, 2020
@monotek monotek mentioned this pull request Jan 30, 2020
Closed
2 tasks
@rknightion rknightion mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monotek @claassistantio @cyriltovena