Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm/loki-stack: add template for the service name to connect to loki #1587

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Helm/loki-stack: add template for the service name to connect to loki #1587

merged 2 commits into from
Jan 27, 2020

Conversation

polar3130
Copy link
Contributor

What this PR does / why we need it:
This PR adds the template for the service name to connect to loki.
Helm chart for loki-stack requires template "loki.serviceName", but it doesn't exist.

Which issue(s) this PR fixes:
Fixes #1566

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@cyriltovena
Copy link
Contributor

should we bump the chart loki-stack version too ?

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e642c28 into grafana:master Jan 27, 2020
@polar3130
Copy link
Contributor Author

@cyriltovena Thx for helping, I forgot to bump the chart ver.

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* Spread the sync load over time

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Move seed to main

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
…grafana#1587)

* add helper for the service name to connect to loki

* Bump loki-chart version.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart for loki-stack requires template "loki.serviceName"...it does not exist
2 participants