Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki frontend docs additions #1611

Merged
merged 8 commits into from
Jan 31, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 30, 2020

What

Adds docs on the query frontend and some configuration examples in k8s.

compress_responses: true

frontend_worker:
address: query-frontend.<namespace>.svc.cluster.local:9095
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think advertising http is better. so they don't have to change their querier setup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the address for the queriers to connect to and they pull from the frontend over grpc. I don't think the queriers can pull over http.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear. I think we should remove this section. and use the downstream property of the frontend config. The frontend will use http to request queriers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to use the frontend without changing anything else in your stack, just by adding a new service.

This is not the best way to use the frontend, I agree but this could be explained.

- name: query-frontend-http-metrics
port: 80
protocol: TCP
targetPort: 80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't target port be align with the frontend server config ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate? The frontend (in this example) listens on 80.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no the config file is set to 9090.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9091 ! hahaha

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #1611 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
+ Coverage   60.69%   60.75%   +0.06%     
==========================================
  Files         107      107              
  Lines        8075     8075              
==========================================
+ Hits         4901     4906       +5     
+ Misses       2787     2784       -3     
+ Partials      387      385       -2
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (+2.29%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSOTM

@cyriltovena cyriltovena merged commit 3e0ee04 into grafana:master Jan 31, 2020
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (b7d23f4) to head (715a241).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
+ Coverage   60.69%   60.75%   +0.06%     
==========================================
  Files         107      107              
  Lines        8075     8075              
==========================================
+ Hits         4901     4906       +5     
+ Misses       2787     2784       -3     
+ Partials      387      385       -2     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants