Added support for imagePullSecrets in Loki Helm chart #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1632 +/- ##
==========================================
- Coverage 61.74% 61.72% -0.03%
==========================================
Files 109 109
Lines 8308 8308
==========================================
- Hits 5130 5128 -2
- Misses 2783 2784 +1
- Partials 395 396 +1
|
cyriltovena
reviewed
Feb 5, 2020
| @@ -1,6 +1,6 @@ | |||
| apiVersion: "v1" | |||
| name: loki-stack | |||
| version: 0.30.0 | |||
| version: 0.31.0 | |||
There was a problem hiding this comment.
Suggested change
| version: 0.31.0 | |
| version: 0.31.1 |
There was a problem hiding this comment.
You have a point there, will update accordingly.
cyriltovena
reviewed
Feb 5, 2020
production/helm/loki/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: "v1" | |||
| name: loki | |||
| version: 0.25.0 | |||
| version: 0.26.0 | |||
There was a problem hiding this comment.
Suggested change
| version: 0.26.0 | |
| version: 0.26.1 |
There was a problem hiding this comment.
You have a point there, will update accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for imagePullSecrets in the Loki Helm chart. This is required if the extra container image is hosted in a local registry.
Code is taken from stable/grafana chart.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist