Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to add informational only feedback for codecov #1647

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mattmendick
Copy link
Contributor

An attempt to try to add the informational flag (to not fail build steps) for the codecov/patch portion of the build steps. This is not in their documentation, but there are lots of other things not correct in their documentation as noted on their community site, so I'm going to try this. Otherwise, I will submit another PR to turn the codecov/patch off and we'll just have stats for the whole project.

An attempt to try to add the `informational` flag (to not fail build steps) for the `codecov/patch` portion of the build steps. This is _not_ in their documentation, but there are lots of other things not correct in their documentation as noted on their community site, so I'm going to try this. Otherwise, I will submit another PR to turn the codecov/patch off and we'll just have stats for the whole project.
@cyriltovena
Copy link
Contributor

I think you need to rebase that branch.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 422a40b into master Feb 6, 2020
@cyriltovena cyriltovena deleted the codecov-make-informational-patch branch February 6, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants