Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased production distributors memory request and limit #1699

Merged

Conversation

pracucci
Copy link
Contributor

What this PR does / why we need it:
Today we found out the current distributors memory request and limit is pretty low and distributors can easily be OOMKilled. In this PR I'm proposing to raise the default vaules.

I've also checked the helm chart but, to my understanding, we're not setting CPU and memory resources for Loki (I assume they're set by the final user). Please let me know if I misunderstood it.

Which issue(s) this PR fixes:
N/A

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 32d4f6c into grafana:master Feb 14, 2020
@pracucci pracucci deleted the increase-distributors-memory-limit branch February 14, 2020 13:23
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants