Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex in pipeline-example.yml #1707

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Fix regex in pipeline-example.yml #1707

merged 1 commit into from
Feb 16, 2020

Conversation

dangoodman
Copy link
Contributor

@dangoodman dangoodman commented Feb 16, 2020

Backslashes must not be escaped inside single quotes:
https://github.com/grafana/loki/blob/master/docs/clients/promtail/stages/regex.md#schema

Spent an hour trying to figure out why no level tags assigned to my logs. Worked fine after the fix.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Backslashes must not be escaped inside single quotes:
https://github.com/grafana/loki/blob/master/docs/clients/promtail/stages/regex.md#schema

Spent an hour trying to figure out why no `level` tags assigned to my logs. Worked fine after the fix.
@claassistantio
Copy link

claassistantio commented Feb 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1707 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   63.23%   63.25%   +0.02%     
==========================================
  Files         121      121              
  Lines        9027     9027              
==========================================
+ Hits         5708     5710       +2     
+ Misses       2899     2898       -1     
+ Partials      420      419       -1
Impacted Files Coverage Δ
pkg/logql/evaluator.go 91.81% <0%> (+0.58%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the trouble.

LGTM

@cyriltovena cyriltovena merged commit f71504f into grafana:master Feb 16, 2020
@dangoodman
Copy link
Contributor Author

Thank you for fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants