Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase discarded samples when line is too long. #1708

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This was omitted earlier and can be useful to build alert base on limit reached per tenant.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1708 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
- Coverage   63.27%   63.25%   -0.02%     
==========================================
  Files         121      121              
  Lines        9027     9028       +1     
==========================================
- Hits         5712     5711       -1     
- Misses       2897     2898       +1     
- Partials      418      419       +1
Impacted Files Coverage Δ
pkg/distributor/validator.go 82.6% <100%> (+0.79%) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (-2.3%) ⬇️
pkg/logql/evaluator.go 91.22% <0%> (-0.59%) ⬇️
pkg/ingester/transfer.go 66.42% <0%> (+1.42%) ⬆️

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-elliott joe-elliott merged commit 4fdfbe8 into grafana:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants