Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goimport local-prefixes configuration to .golangci.yml #1710

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

adityacs
Copy link
Collaborator

@adityacs adityacs commented Feb 18, 2020

What this PR does / why we need it:

  1. Add goimport local-prefixes configuration to .golangci.yml
  2. Formatted imports unders pkg/ and cmd/
  3. Updated CONTRIBUTING.md for Coding Standards

Which issue(s) this PR fixes:
Fixes #1348

Checklist

  • Documentation added

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #1710 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1710   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         121      121           
  Lines        9027     9027           
=======================================
  Hits         5784     5784           
  Misses       2841     2841           
  Partials      402      402
Impacted Files Coverage Δ
pkg/logentry/stages/timestamp.go 87.34% <ø> (ø) ⬆️
pkg/logcli/output/default.go 100% <ø> (ø) ⬆️
pkg/logql/marshal/marshal.go 75.86% <ø> (ø) ⬆️
pkg/logql/range_vector.go 97.56% <ø> (ø) ⬆️
pkg/promtail/client/batch.go 94.73% <ø> (ø) ⬆️
cmd/fluent-bit/out_loki.go 5.79% <ø> (ø) ⬆️
pkg/distributor/ingestion_rate_strategy.go 88.88% <ø> (ø) ⬆️
pkg/querier/queryrange/stats.go 100% <ø> (ø) ⬆️
pkg/ingester/transfer.go 66.42% <ø> (+1.42%) ⬆️
pkg/logentry/stages/tenant.go 95.12% <ø> (ø) ⬆️
... and 34 more

@adityacs
Copy link
Collaborator Author

Build 2027 shows error when linter fails

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit f9ff2a4 into grafana:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goimports and local package
3 participants