Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in templating when extracted key has nil value #1765

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

adityacs
Copy link
Contributor

@adityacs adityacs commented Mar 2, 2020

What this PR does / why we need it:
Fix error in templating when extracted key has nil value

Which issue(s) this PR fixes:
Fixes #1764

Checklist

  • Tests updated

@codecov-io
Copy link

Codecov Report

Merging #1765 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1765      +/-   ##
=========================================
+ Coverage   64.36%   64.4%   +0.04%     
=========================================
  Files         121     121              
  Lines        9081    9081              
=========================================
+ Hits         5845    5849       +4     
+ Misses       2833    2831       -2     
+ Partials      403     401       -2
Impacted Files Coverage Δ
pkg/logentry/stages/template.go 86.66% <100%> (ø) ⬆️
pkg/ingester/transfer.go 66.42% <0%> (+1.42%) ⬆️
pkg/promtail/targets/tailer.go 78.16% <0%> (+2.29%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityacs LGTM!

@slim-bean slim-bean merged commit 75ef5c8 into grafana:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template stage does not work with partially filled json log messages
3 participants