Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Cleanup #1767

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Dashboard Cleanup #1767

merged 6 commits into from
Mar 3, 2020

Conversation

joe-elliott
Copy link
Member

What this PR does / why we need it:

  • Removes references to internal envs
  • Fixes log dashboard (was referring to a no longer existing data source)
  • Improves log dashboard "memory" title => "working set"
  • Add refresh to Loki operational variables

@joe-elliott
Removed env references from operational dashboard
16fdad6 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Updated refresh on template vars
1cbf511 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Standard formatting
6f1e4bb 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Removed env references
5439d34 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Added queries
b1a5712 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
memory => working set
c5699ba 
Signed-off-by: Joe Elliott <number101010@gmail.com>
slim-bean
slim-bean approved these changes Mar 3, 2020
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Pls squash when you merge

@joe-elliott joe-elliott merged commit 61bfa20 into grafana:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-elliott @slim-bean