fluentbit: JSON encoding: avoid base64 encoding of []byte inside other slices #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1889 Signed-off-by: Mikhail Gusarov <misha@ridge.co>
|
|
dottedmag
changed the title
|
Nice ! Looks good ! Are you able to sign the CLA ? |
cyriltovena
reviewed
Apr 2, 2020
|
@cyriltovena Sure, let me pass it to the legal dept to approve. |
cyriltovena
approved these changes
Apr 2, 2020
|
@cyriltovena All done. |
slim-bean
pushed a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Without this fix any strings inside arrays (directly or indirectly) end up being
base64-encoded.
Which issue(s) this PR fixes:
Fixes #1889
Special notes for your reviewer:
Checklist