Add no-file and keep-file log option for docker driver. #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default no-file is false, this means the driver will create json log files that can be used to run `docker logs` command. If no-file is true, no files are created and so `docker log` won't work. This allow the ability to run the driver without caring of space left on the host. keep-file tells the driver to keep file even after the container has been stopped, by default this options is false. This means files are cleaned up once containers are stopped and not history is left to be used for `docker logs`. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
==========================================
+ Coverage 64.57% 64.65% +0.07%
==========================================
Files 125 125
Lines 9477 9477
==========================================
+ Hits 6120 6127 +7
+ Misses 2929 2925 -4
+ Partials 428 425 -3
|
cyriltovena
changed the title
ushuz
reviewed
Apr 8, 2020
ushuz
reviewed
Apr 8, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
@ushuz Appreciate the review, I've fixed those comment, PTAL ! ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default no-file is false, this means the driver will create json log files that can be used to run
docker logscommand.If no-file is true, no files are created and so
docker logwon't work. This allow the ability to run the driver without caring of space left on the host.keep-file tells the driver to keep file even after the container has been stopped, by default this options is false. This means files are cleaned up once containers are stopped and not history is left to be used for
docker logs.Fixes #1868
Fixes #1886
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com