Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified that the api push path needs to be specified. #1925

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

wardbekker
Copy link
Member

What this PR does / why we need it:

Clarified that the api push path needs to be specified in client.url property. Otherwise folks will run into this message:

level=error ts=2020-04-09T15:08:53.408999Z caller=client.go:247 component=client host=example.com:3100 msg="final error sending batch" status=404 error="server returned HTTP status 404 Not Found (404): 404 page not found"

clarified the api push path needs to be specified. Otherwise folks see this message:

level=error ts=2020-04-09T15:08:53.408999Z caller=client.go:247 component=client host=example.com:3100 msg="final error sending batch" status=404 error="server returned HTTP status 404 Not Found (404): 404 page not found"
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8f9c065 into master Apr 13, 2020
@cyriltovena cyriltovena deleted the wardbekker-promtail-path-clarification branch April 13, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants