Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki Update the cut block size counter when creating a memchunk from byte slice #1946

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Loki Update the cut block size counter when creating a memchunk from byte slice #1946

merged 3 commits into from
Apr 16, 2020

Conversation

slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Apr 15, 2020 •
edited
Loading

I expanded the scope of this a little to fix #1412 where transferred chunks do not have the block size or the target size set correctly.

cyriltovena
cyriltovena approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean
Copy link
Collaborator Author

/cc @rfratto

cyriltovena
cyriltovena approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good. Might be a good candidate later to add in the chunk header.

@slim-bean slim-bean merged commit b5b3e78 into master Apr 16, 2020
@slim-bean slim-bean deleted the fix-cut-block-counter branch April 16, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chunk utilization is incorrect for transferred chunks
2 participants
@slim-bean @cyriltovena