Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update docker.md #1966

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Docs: Update docker.md #1966

merged 1 commit into from
Apr 20, 2020

Conversation

oddlittlebird
Copy link
Contributor

@oddlittlebird oddlittlebird commented Apr 20, 2020

What this PR does / why we need it: Fixes the commands for Windows machines. Windows doesn't recognize $PWD or -config. You need to enter the path and use --config.

Special notes for your reviewer: Please make sure the statements are true for Linux. I can verify they are true for Windows.

Checklist

  • Documentation added
  • Tests updated

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oddlittlebird oddlittlebird merged commit 84e6b65 into master Apr 20, 2020
@oddlittlebird oddlittlebird deleted the Clarified-Docker-instructions branch April 20, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants