Docs: Added labels content #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great thanks @oddlittlebird! I think we should also add links to these new pages via the table of contents: For getting started: https://github.com/grafana/loki/blob/master/docs/README.md and https://github.com/grafana/loki/blob/master/docs/getting-started/README.md For best practices: I think we should add a new entry in: https://github.com/grafana/loki/blob/master/docs/README.md and I think a new README.md in the new best-practices folder. |
Signed-off-by: Ed Welch <edward.welch@grafana.com>
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
==========================================
+ Coverage 64.46% 64.48% +0.01%
==========================================
Files 131 131
Lines 10038 10038
==========================================
+ Hits 6471 6473 +2
+ Misses 3084 3083 -1
+ Partials 483 482 -1
|
|
Excited to get this in. @oddlittlebird Would you be willing to make @slim-bean's suggestions? |
|
@owen-d , the links have already been applied. |
owen-d
approved these changes
Apr 30, 2020
|
I missed Ed including his changes, we should have merged this a few days back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Took content from Ed's blog post and added it to the documentation. One topic is in Getting started, not sure that is the best place but did not see a better one. The other topic is in a new folder called Best Practices, which I hope you guys will add to over time.
It is needed because there is currently almost next to no content on labeling.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: You might want to change some of the tone or remove some text to make it fit with the rest of your documentation.
Checklist