Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds config to disable HTTP and GRPC server in Promtail. #2004

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

cyriltovena
Copy link
Contributor

Fixes #1991.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Fixes grafana#1991.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyriltovena cyriltovena merged commit 34f9c60 into grafana:master Apr 29, 2020
@candlerb
Copy link
Contributor

LGTM too.

Regarding the sample configs which show grpc_listen_port: 0 - were these really intended to suggest it's a good idea to run grpc on a random port? I wonder why?

@cyriltovena
Copy link
Contributor Author

Which config ? it should not !

@cyriltovena
Copy link
Contributor Author

Yes each of those doesn't require GRPC. We could just remove it but binding to a random port ensure we don't fail for a default port in use.

@candlerb
Copy link
Contributor

Would it make sense to have separate http_disable and grpc_disable instead?

@cyriltovena
Copy link
Contributor Author

Yes it would but we're using a library and that would need to be done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to disable promtail http/grpc servers, and document behaviour for port = 0
3 participants