Change image tag from 1.4.1 to 1.4.0 in Helm chart #2015
Conversation
Change image tag from 1.4.1 to 1.4.0 to make the chart work as the image with 1.4.1 runs into errors while deploying
|
|
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
==========================================
+ Coverage 63.70% 63.85% +0.14%
==========================================
Files 133 133
Lines 10179 10179
==========================================
+ Hits 6485 6500 +15
+ Misses 3205 3188 -17
- Partials 489 491 +2
|
|
Thanks @etashsingh ! I think however if i'm following the issue correctly we need to change the promtail chart image 1.4.0 not the loki chart, could you make this update please? |
|
@slim-bean |
|
looking better! we should also increase the loki-stack chart version like you had before. (anytime we increase the chart version for either loki or promtail we increase the lok-stack version) |
|
@slim-bean didn't know that! |
There was a problem hiding this comment.
LGTM! We'll make sure all the tests pass and get this merged!
Thanks for your first contribution @etashsingh 🎉
|
@slim-bean you're welcome and thanks a lot for helping me out! |
* Change image tag from 1.4.1 to 1.4.0 Change image tag from 1.4.1 to 1.4.0 to make the chart work as the image with 1.4.1 runs into errors while deploying * Update chart version value * update loki stack chert version * Changed image tag value from 1.4.1 to 1.4.0 * Update values.yaml * Update Chart.yaml * Update Chart.yaml * Update Chart.yaml * Update loki-stack chart version
Docker image tag changed from 1.4.1 back to 1.4.0 as it was running into an error while deploying.
Updated chart version values
Provides solution to issue: #1979
Signed-off-by: Etash Singh etashsingh29@gmail.com