make loki_ingester_memory_streams Gauge per tenant.
#2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Welch <edward.welch@grafana.com>
slim-bean
added a commit
that referenced
this pull request
Apr 30, 2020
Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit 872a998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently approximate this by subtracting
loki_ingester_streams_created_total-loki_ingester_streams_removed_total(which have a tenanat label) however you can only do this if you don't use a rate, and if you don't use a rate you don't handle counter resets properly.Separately the rate of streams created vs streams removed is useful to track churn per tenant, but it would be good to have a per tenant way of tracking active streams
Signed-off-by: Ed Welch edward.welch@grafana.com