Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by Cortex where the use of custom protobuf types allows to improve performance of serialization.(see https://github.com/cortexproject/cortex/blob/8fe97dcc707a3e774229d9fd3b20425214e0ac9b/pkg/ingester/client/timeseries.go#L174)
This contains 2 optimization:
I've run this for a while in a dev environment and everything looks good. This mostly affect everything that serializes Streams.
Benchmark:
On drawback of custom type is gogo/protobuf#509 However I've made sure that a pointer is used where needed.
This is just a step forward I think next step is to pre-allocate data for request/response like Cortex does.