Docker driver: Allow to provision external pipeline files to plugin #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cyriltovena
reviewed
May 8, 2020
cmd/docker-driver/config.json
Outdated
| "destination": "/data", | ||
| "type": "none", | ||
| "options": ["bind", "ro"], | ||
| "settable": ["source", "destination"] |
There was a problem hiding this comment.
can you indent this please ?
cyriltovena
approved these changes
May 8, 2020
There was a problem hiding this comment.
Really love that change. @bkmit Thanks a lot for this !
There's just one nit if you can fix it before we merge.
Thank you !
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* adding retry options for cassandra and updating docs * adjusting some naming based on feedback Signed-off-by: Ken Haines <khaines@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add mounts section to docker plugin config.json.
This allow to make host directory with pipeline files accessable to docker driver plugin.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist