Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix spelling of per second in code #2055

Merged
merged 1 commit into from
May 8, 2020

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented May 7, 2020

What this PR does / why we need it:
Follow up to my previous PR to fix spelling of "per second" in code.

I hope no backwards incompatible changes are introduced, please let me know if it's the case!

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 requested a review from cyriltovena May 7, 2020 14:09
@aknuds1 aknuds1 changed the title Chore: Fix spelling of per second Chore: Fix spelling of per second in code May 7, 2020
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will cause stats to be wrong during rollout but that's pretty much all. Also you have now integration in Grafana for this do you need to update it ?

@aknuds1
Copy link
Contributor Author

aknuds1 commented May 7, 2020

LGTM

This will cause stats to be wrong during rollout but that's pretty much all. Also you have now integration in Grafana for this do you need to update it ?

@cyriltovena Sorry, I simply don't know what I would eventually have to update in Grafana. I noticed this spelling error when looking at the stats part of the Inspect drawer in Grafana.

@cyriltovena
Copy link
Contributor

@cyriltovena
Copy link
Contributor

I'm not sure we have to fix anything just asking really.

/cc @davkal does that look ok to merge ?

@davkal
Copy link
Contributor

davkal commented May 7, 2020

LGTM, wont affect my Explore hack.

@cyriltovena cyriltovena merged commit d975b1f into master May 8, 2020
@cyriltovena cyriltovena deleted the bugfix/fix-per-seconds branch May 8, 2020 14:22
cyriltovena added a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* Upgrade gogo/protobuf to 1.3.0

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants