Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make <placeholders> visible #2092

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

i-takizawa
Copy link
Contributor

@i-takizawa i-takizawa commented May 19, 2020

What this PR does / why we need it:
<placeholders> was unintentionally parsed so the text was not being displayed.
Added backslashes to make it visible and for nicer reading of filenames.

Checklist

  • Documentation added
  • Tests updated

Added backslashes to make<placeholders> visible in parsed text.
@CLAassistant
Copy link

CLAassistant commented May 19, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2092 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
+ Coverage   61.28%   61.30%   +0.01%     
==========================================
  Files         146      146              
  Lines       11187    11187              
==========================================
+ Hits         6856     6858       +2     
+ Misses       3785     3784       -1     
+ Partials      546      545       -1     
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+2.27%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8cbeb53 into grafana:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants